Drop dependency on distutils#651
Merged
Merged
Conversation
pavoljuhas
reviewed
Jan 23, 2024
pavoljuhas
reviewed
Jan 23, 2024
pavoljuhas
reviewed
Jan 24, 2024
Collaborator
|
Based on http://sponge2/200604ce-5698-4ab1-88be-403a0f5eff1c it seems we need to either upgrade the tensorflow dependency or somehow tell bazel to build with Python <= 3.11. |
Collaborator
Author
|
@pavoljuhas all checks pass, ptal |
pavoljuhas
approved these changes
Jan 24, 2024
Collaborator
pavoljuhas
left a comment
pavoljuhas
left a comment
There was a problem hiding this comment.
Nice, thanks for tracking this down!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error #632 originally fixed in #633 has made a comeback https://fusion2.corp.google.com/invocations/f88845c0-24f7-4c02-b99d-74424ce80a75/targets/qsim%2Fmacos%2Fpresubmit/log.
Fix: Replace
distutilswithpackagingas per https://peps.python.org/pep-0632/#migration-advice